-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add command-line option "dns-cache-size" for trust-dns #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please check the clippy logs and fix those warnings. |
zedifen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve code
|
Maybe mention this change in README? |
Sounds great! |
|
Tested, works great :) |
|
I'm going to rebase this branch 😊 Update: rebased. |
|
Oh, by the way, currently the musl cross-build would fail on stable rust toolchain with recent ziglang versions. Moving to rust nightly would fix it. Or, the rust is going to stabilize the new musl version shipped with the toolchain in 1.71. See https://blog.rust-lang.org/2023/05/09/Updating-musl-targets.html One may refer to the PR in my fork of the repository. https://github.com/zedifen/shadowsocks-rust/pull/4 |
|
I am still waiting trust-dns to stablize its new version, so it is Ok to wait 1.71 until making the next release. |
See also #1215
This PR adds a command-line option
--dns-cache-sizetosslocal,ssserverandssmanager, allowing users to configure thecache_sizeofResolverOptsin trust-dns.I'm not sure if the current solution is appropriate, i.e. to pass
dns_cache_sizeall the way tocreate_resolver. How about I pass thedns_cache_sizethrough aResolverOpts?