Skip to content

Remove dependency to rustc-serialize. #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2017
Merged

Remove dependency to rustc-serialize. #191

merged 1 commit into from
May 19, 2017

Conversation

@nical
Copy link
Contributor

@nical nical commented May 3, 2017 •
edited by larsbergstrom
Loading

rustc-serialize is deprecated in favor of serde and servo has moved to serde which means we don't need to carry this dependency anymore.

This change is Reviewable

@nical
Copy link
Contributor Author

nical commented May 3, 2017

r? @nox

Note that I didn't bump euclid's version (not sure whether we should do this for every commit introducing a breaking change or just when publishing).

@kvark
Copy link
Member

kvark commented May 3, 2017

You also need to remove extern crate rustc_serialize; as well as all RustDecodable/RustEncodable mentions, replacing them with Serde's stuff.

@nical
Copy link
Contributor Author

nical commented May 3, 2017

rah! Who would have thought that trying to send a PR by clicking around in github without opening a text editor was not a good idea.

@nical
Copy link
Contributor Author

nical commented May 3, 2017 •
edited
Loading

Don't review/land just yet, I'm looking into getting serde wired up properly (not sure if PhantomData is as much of a pain with serde_derive as it is with simple derives).

Edit: nevermind, serde traits are already manually implemented for all euclid types. It should be good to go.

kvark
kvark suggested changes May 4, 2017
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now :)
You still need to implement serde traits for points and sizes.

@nical
Copy link
Contributor Author

nical commented May 4, 2017

You still need to implement serde traits for points and sizes.

It's already implemented by the define_matrix macro.

kvark
kvark approved these changes May 4, 2017
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nical
indeed!

@nox
Copy link
Contributor

nox commented May 9, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

📌 Commit 5e33c3e has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⌛ Testing commit 5e33c3e with merge 3b15210...

bors-servo pushed a commit that referenced this pull request May 9, 2017
Auto merge of #191 - nical:patch-1, r=nox
3b15210 
Remove dependency to rustc-serialize.

rustc-serialize is deprecated in favor of serde and servo has moved to serde which means we don't need to carry this dependency anymore.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/191)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

💔 Test failed - status-travis

@emilio
Copy link
Member

emilio commented May 9, 2017

@bors-servo retry

  • Spurious failure?

@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⌛ Testing commit 5e33c3e with merge 67545e1...

bors-servo pushed a commit that referenced this pull request May 9, 2017
Auto merge of #191 - nical:patch-1, r=nox
67545e1 
Remove dependency to rustc-serialize.

rustc-serialize is deprecated in favor of serde and servo has moved to serde which means we don't need to carry this dependency anymore.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/191)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

💔 Test failed - status-travis

@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2017

☔ The latest upstream changes (presumably #193) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm
Copy link
Member

jdm commented May 18, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2017

🔒 Merge conflict

@jdm
Copy link
Member

jdm commented May 18, 2017

Bah, merge conflict. It should be possible to merge this after a rebase since #193 merged.

@nical
Remove dependency to rustc-serialize.
1f19d98 
rustc-serialize is deprecated in favor of serde and servo has moved to serde which means we don't need to carry this dependency anymore.
@nical nical mentioned this pull request May 19, 2017
Closed
@nical
Copy link
Contributor Author

nical commented May 19, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2017

⌛ Trying commit 1f19d98 with merge 757d3de...

bors-servo pushed a commit that referenced this pull request May 19, 2017
Auto merge of #191 - nical:patch-1, r=<try>
757d3de 
Remove dependency to rustc-serialize.

rustc-serialize is deprecated in favor of serde and servo has moved to serde which means we don't need to carry this dependency anymore.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/191)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2017

☀️ Test successful - status-travis
State: approved= try=True

@nical
Copy link
Contributor Author

nical commented May 19, 2017

@bors-servo r=nox

@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2017

📌 Commit 1f19d98 has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2017

⌛ Testing commit 1f19d98 with merge 5f796a1...

bors-servo pushed a commit that referenced this pull request May 19, 2017
Auto merge of #191 - nical:patch-1, r=nox
5f796a1 
Remove dependency to rustc-serialize.

rustc-serialize is deprecated in favor of serde and servo has moved to serde which means we don't need to carry this dependency anymore.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/191)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2017

☀️ Test successful - status-travis
Approved by: nox
Pushing 5f796a1 to master...

@bors-servo bors-servo merged commit 1f19d98 into servo:master May 19, 2017
@nical nical deleted the patch-1 branch May 19, 2017 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kvark kvark kvark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nical @kvark @nox @bors-servo @emilio @jdm