Skip to content

Conversation

@nical
Copy link
Contributor

@nical nical commented Aug 23, 2016

A few sanity tests to the matrix types.


This change is Reviewable

@nical
Copy link
Contributor Author

nical commented Aug 23, 2016

My first non-breaking change :) It's pretty basic, but I doubt I'll manage to break matrix multiplication again after that!
cc @nox
r? @pcwalton

src/matrix4d.rs Outdated
#[cfg(test)]
mod tests {
use point::Point2D;
use point::{ Point2D, Point3D };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove dem spaces.

@nox
Copy link
Contributor

nox commented Sep 6, 2016

r=me with the nit fixed.

@bors-servo delegate+

@bors-servo
Copy link
Contributor

✌️ @nical can now approve this pull request

@nox
Copy link
Contributor

nox commented Sep 9, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 339c99a has been approved by nox

@bors-servo
Copy link
Contributor

⚡ Test exempted - status

@bors-servo bors-servo merged commit 339c99a into servo:master Sep 9, 2016
bors-servo pushed a commit that referenced this pull request Sep 9, 2016
Add tests for Matrix2D and Matrix4D.

A few sanity tests to the matrix types.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/163)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants