Add OAuth authentication support to HTTP call task #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
reviewed
Aug 19, 2025
fjtirado
reviewed
Aug 19, 2025
fjtirado
reviewed
Aug 19, 2025
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/OAuth2AuthProvider.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 19, 2025
fjtirado
reviewed
Aug 19, 2025
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/oauth/HttpRequestBuilder.java
Outdated
Show resolved
Hide resolved
treblereel
force-pushed
the
oauth_http
branch
2 times, most recently
from
31b14ff to
8a565a4
Compare
fjtirado
reviewed
Aug 20, 2025
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/OAuth2AuthProvider.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 20, 2025
.../http/src/main/java/io/serverlessworkflow/impl/executors/http/oauth/AccessTokenProvider.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 20, 2025
.../http/src/main/java/io/serverlessworkflow/impl/executors/http/oauth/AccessTokenProvider.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 20, 2025
.../http/src/main/java/io/serverlessworkflow/impl/executors/http/oauth/AccessTokenProvider.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 20, 2025
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/oauth/HttpRequestBuilder.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 20, 2025
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/oauth/InvocationHolder.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 20, 2025
fjtirado
reviewed
Aug 20, 2025
impl/jwt-impl/src/main/java/io/serverlessworkflow/impl/http/jwt/DefaultJWTConverter.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 20, 2025
impl/jwt-impl/src/main/java/io/serverlessworkflow/impl/http/jwt/DefaultJWTImpl.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 20, 2025
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
treblereel
force-pushed
the
oauth_http
branch
4 times, most recently
from
e46b959 to
2623307
Compare
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
fjtirado
reviewed
Aug 21, 2025
Comment on lines
51
to
53
| } catch (IllegalArgumentException e) { | ||
| throw new IllegalStateException("Failed to parse JWT token: " + e.getMessage(), e); | ||
| } |
There was a problem hiding this comment.
Why not letting the Illegal argument exception to escalate?. Unless Im missing something, adding an additional exception here, in my opinion, only pollutes the exception stack trace witn an additional one
fjtirado
reviewed
Aug 21, 2025
...http/src/main/java/io/serverlessworkflow/impl/executors/http/oauth/TokenResponseHandler.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Aug 21, 2025
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
fjtirado
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
#691
Special notes for reviewers:
Additional information (if needed):