Skip to content

Conversation

@dampee
Copy link
Contributor

@dampee dampee commented Jan 27, 2021

You need to use path, as this is a mandatory parameter.

Copy pasting this code won't give you any file logging (and no exception & error)

You need to use path, as this is a mandatory parameter.
@nblumhardt
Copy link
Member

Hi @dampee! For RollingFile, the parameter name is pathFormat: https://github.com/serilog/serilog-sinks-rollingfile/blob/dev/src/Serilog.Sinks.RollingFile/RollingFileLoggerConfigurationExtensions.cs#L63

If you use File then it's path.

We should probably change the example to use File, since the RollingFile sink is deprecated... 🤔

@dampee
Copy link
Contributor Author

dampee commented Jan 31, 2021

We should probably change the example to use File, since the RollingFile sink is deprecated... 🤔

Yeah, that was the reason for my PR.

@nblumhardt nblumhardt merged commit c1803e0 into serilog:dev Feb 1, 2021
@nblumhardt
Copy link
Member

Thanks @dampee 👍

@dampee dampee deleted the patch-1 branch February 1, 2021 20:41
@nblumhardt nblumhardt mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants