Skip to content

Upgrade to Serilog.Settings.AppSettings v2.1.1 breaks calls to .ReadFrom.AppSettings() #13

@tsimbalar

Description

@tsimbalar

I think it is related to the changes from #10 and #12

The following code no longer compiles after upgrading from v2.1.0 to v2.1.1

    public class LogConfig
    {
        static public void Configure()
        {
            var loggerConfiguration = new LoggerConfiguration().ReadFrom.AppSettings();
            Log.Logger = loggerConfiguration.CreateLogger();
        }
    }

image

Error	CS0121	The call is ambiguous between the following methods or properties: 'AppSettingsLoggerConfigurationExtensions.AppSettings(LoggerSettingsConfiguration, string)' and 'AppSettingsLoggerConfigurationExtensions.AppSettings(LoggerSettingsConfiguration, string, string)'

I guess probably only one of the overloads should have optional params.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions