Skip to content

Add a safety comment to unsafe block #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add a safety comment to unsafe block #1213

merged 1 commit into from
Nov 15, 2024

Conversation

@djmitche
Copy link
Contributor

@djmitche djmitche commented Nov 14, 2024

I noted the lack of a comment when performing a review. The implementation is safe, just not documented.

dtolnay
dtolnay approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 75ed447 into serde-rs:master Nov 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djmitche @dtolnay