Skip to content

Conversation

ssiddhantsharma
Copy link
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 6, 2018
@SendGridDX
Copy link

SendGridDX commented Feb 6, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files           3        3           
  Lines         170      170           
=======================================
  Hits          148      148           
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36693c5...0323536. Read the comment docs.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 28, 2018
@thinkingserious thinkingserious merged commit c751b0a into sendgrid:master Mar 8, 2018
@thinkingserious
Copy link
Contributor

Hello @ssiddhantsharma,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants