Skip to content

Call correct process method in Group. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Call correct process method in Group. #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9420264
Call correct process method in Group.
Nov 17, 2021
5eced05
Fixed flush test
Nov 17, 2021
7f9c4d2
Get more test information
Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Segment/Events.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,6 @@ extension Analytics {
exceptionFailure("Could not parse traits.")
}
}
process(event: event)
process(incomingEvent: event)
}
}
4 changes: 2 additions & 2 deletions Tests/Segment-Tests/Analytics_Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ final class Analytics_Tests: XCTestCase {
analytics.track(name: "test")

let newBatchCount = analytics.storage.eventFiles(includeUnfinished: true).count
// 1 new temp file, and 1 new finished file.
XCTAssertTrue(newBatchCount == currentBatchCount + 2)
// 1 new temp file
XCTAssertTrue(newBatchCount == currentBatchCount + 1, "New Count (\(newBatchCount)) should be \(currentBatchCount) + 1")
}

func testVersion() {
Expand Down