Skip to content

Cleaned up file storage removal code #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Cleaned up file storage removal code #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions Sources/Segment/Utilities/Storage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ internal class Storage: Subscriber {
syncQueue.sync {
// remove the temp file.
try? FileManager.default.removeItem(atPath: file.path)
// remove the unfinished event storage file.
let actualFile = file.deletingPathExtension()
try? FileManager.default.removeItem(atPath: actualFile.path)
}
}

Expand Down Expand Up @@ -308,7 +305,7 @@ extension Storage {

let tempFile = file.appendingPathExtension(Storage.tempExtension)
do {
try FileManager.default.copyItem(at: file, to: tempFile)
try FileManager.default.moveItem(at: file, to: tempFile)
} catch {
Analytics.segmentLog(message: "Unable to rename to temp: \(file), Error: \(error)", kind: .error)
}
Expand Down