Skip to content

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented Nov 5, 2021

  • Modified timeline to determine enablement by a combination of event data as well as settings data.
  • Added method hasIntegrationSettings.
  • Removed confusing state entries re integrations vs. settings for integrations.
  • Modified Segment destination to construct integration object as it's being sent to segment rather than try to do it beforehand.

@migs647
Copy link
Contributor

migs647 commented Nov 5, 2021

Liking this direction

Copy link

@oscb oscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@alanjcharles alanjcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my brain hurts but it looks good and make sense

Copy link
Contributor

@prayansh prayansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Added some comments for more clarification

@bsneed bsneed merged commit c09663c into main Nov 10, 2021
@bsneed bsneed deleted the bsneed/integration_fixes branch November 10, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants