Made working with and modifying payloads within plugins much simpler. #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Oct 25, 2021
bsneed
commented
- Logging is now available outside of an analytics instance.
- Added convenience methods for modifying the integrations/context.
- Added subscripts and methods for JSON value accessing/setting.
- Optimized search order for keypath handlers.
- Unit Tests
added 10 commits
October 19, 2021 11:42
prayansh
reviewed
Oct 25, 2021
migs647
reviewed
Oct 25, 2021
migs647
reviewed
Oct 25, 2021
| loggerPlugin.log(log, destination: .log) | ||
| } | ||
| } else { | ||
| #if DEBUG |
Contributor
There was a problem hiding this comment.
I'm debating if we should change this from DEBUG to DEBUGLOG, that way our console doesn't get spammed and we can easily disable this and use Console as a backup. Thoughts?
Contributor
Author
There was a problem hiding this comment.
I'm not really following what you mean here. Please hit me up on slack.
migs647
reviewed
Oct 25, 2021
migs647
reviewed
Oct 25, 2021
migs647
reviewed
Oct 25, 2021
migs647
reviewed
Oct 25, 2021
migs647
reviewed
Oct 25, 2021
migs647
approved these changes
Oct 25, 2021
Contributor
migs647
left a comment
migs647
left a comment
There was a problem hiding this comment.
LGTM. Just maybe some documentation and remove some commented tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.