update ISO 8601 utility to remove timezone colon #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
hi @tcldr can your fetch and merge the upstream commits? this pr should be able to build after that. thanks! |
bsneed
approved these changes
Oct 26, 2021
Contributor
|
Thanks so much @tcldr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of a colon in the ISO 8601 timestamps seems to cause an issue whereby timestamps that rely on the originalTimestamp property, default to the
sentAtdate. I imagine this is due to Segment servers rejecting the malformed timestamp and defaulting to a known value. Removing the colon appears to fix that.This closes #75