Skip to content

Refactor screen fun param from screenTitle to title. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2021
Merged

Refactor screen fun param from screenTitle to title. #56

merged 2 commits into from
Aug 31, 2021

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented Aug 31, 2021

  • Renames param for screen() to title.
  • Updates readme to reflect current API.

migs647
migs647 approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsneed bsneed merged commit 36c356a into main Aug 31, 2021
@bsneed bsneed deleted the bsneed/screentitle branch August 31, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenxi-zeng wenxi-zeng wenxi-zeng approved these changes

+1 more reviewer

@migs647 migs647 migs647 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bsneed @migs647 @wenxi-zeng