Improve startup plugin collection. #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Aug 19, 2021
bsneed
commented
- Moved required per-platform plugins to VendorSystem.
- Refactored startup sequence to fetch from VendorSystem and then apply lifecycle stuff.
prayansh
reviewed
Aug 19, 2021
| if configuration.values.trackApplicationLifecycleEvents { | ||
| #if os(iOS) || os(tvOS) | ||
| plugins += [iOSLifecycleMonitor(), iOSLifecycleEvents(), DeviceToken()] | ||
| plugins.append(iOSLifecycleEvents()) |
Contributor
There was a problem hiding this comment.
would it make more sense to provide the lifecycleEvents plugin via the vendor system as well?
Contributor
Author
There was a problem hiding this comment.
I think that would add clutter in the long term if/when we have more things that fall into that bucket.
prayansh
approved these changes
Aug 19, 2021
Contributor
prayansh
left a comment
prayansh
left a comment
There was a problem hiding this comment.
LGTM, just a suggestion on providing the lifecycleEvent plugin via vendor system, to potentially remove macro code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.