Adds key mapping support for use in destination plugins. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migs647
reviewed
Aug 12, 2021
| // MARK: - Helpers | ||
|
|
||
| extension Dictionary where Key == String, Value == Any { | ||
| internal func mapKeys(_ keys: [String: String], valueTransform: ((_ key: Key, _ value: Value) -> Any)? = nil) throws -> [Key: Value] { |
Contributor
There was a problem hiding this comment.
Do you need = nil on there?
Contributor
Author
There was a problem hiding this comment.
Yeah, cuz I want it to be optional. They likely just want to map keys, at which point, the values won't be transformed.
migs647
reviewed
Aug 12, 2021
migs647
reviewed
Aug 12, 2021
migs647
reviewed
Aug 12, 2021
| if !(newValue is [Key: Value]), let transform = valueTransform { | ||
| // it's not a dictionary apply our transform. | ||
|
|
||
| // note: if it's an array, we've processed any dictionaries inside |
migs647
reviewed
Aug 12, 2021
| return newValue | ||
| }).dictionaryValue | ||
|
|
||
| XCTAssertTrue(output!["AKey1"] as! Int == 11) |
Contributor
There was a problem hiding this comment.
Can we change these to as? so we fail the unit test instead of crash the unit tests?
Contributor
Author
There was a problem hiding this comment.
We could I guess, though that doesn't really bother me. We'd need to go hit a bunch of other tests as well as that's my MO for unit tests. FORCE UNWRAP ALL THE THINGS!
migs647
approved these changes
Aug 12, 2021
Contributor
migs647
left a comment
migs647
left a comment
There was a problem hiding this comment.
LGTM -- just some nitpicks
alanjcharles
approved these changes
Aug 12, 2021
Contributor
alanjcharles
left a comment
alanjcharles
left a comment
There was a problem hiding this comment.
looks great. Awesome idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapKeysfunction to JSON object w/ optional value transform step.