Fixes issue w/ UIApplication.shared not being supported in iOS App Extensions #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Aug 6, 2021
bsneed
commented
- Fixes Xcode 13b4: 'shared' is unavailable in application extensions for iOS: Use view controller based solutions where appropriate instead. #34
- Adds isAppExtension check.
- Changes application values in lifecycle func's to be optional.
- Generally accounts for the possibility that we may not have a UIApplication to pass around.
migs647
approved these changes
Aug 6, 2021
Contributor
migs647
left a comment
migs647
left a comment
There was a problem hiding this comment.
LGTM. Wouldn't mind some comment cleanup on the safeShared accessor. Was a bit confusing at first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.