Atomicity updates for Thread Sanitizer warnings #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Jun 27, 2023
bsneed
commented
- Refactor the Atomic property wrapper.
- Fix lack of atomicity in CountBasedFlushPolicy
- Added documentation and references in code re atomicity changes.
- Fixes Thread Sanitizer: Swift access race in Segment.CountBasedFlushPolicy.count.modify : Swift.Int at 0x11a75f4c0 #227
didiergarcia
approved these changes
Jun 27, 2023
| private let lock = NSLock() | ||
| public class Atomic<T> { | ||
| private var value: T | ||
| private let queue = DispatchQueue(label: "com.segment.atomic.\(UUID().uuidString)") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.