Storage hardening; Add error handling capabilities. #163
Conversation
bsneed
force-pushed
the
bsneed/storage_fixes
branch
from
f5f2eb3 to
9e85e20
Compare
bsneed
force-pushed
the
bsneed/storage_fixes
branch
from
fd25215 to
81cc70b
Compare
bsneed
changed the title
oscb
left a comment
oscb
left a comment
There was a problem hiding this comment.
Left a few questions and small comments, but overall I think this looks good!
| } | ||
|
|
||
| @discardableResult | ||
| func errorHandler(_ value: @escaping (Error) -> Void) -> Configuration { |
There was a problem hiding this comment.
Just curious as to why it returns the Configuration ?
There was a problem hiding this comment.
The config methods are all chainable and this continues that. Makes is so you can do ...
let analytics = Configuration(writeKey: "1234")
.trackLifecycleEvents(true)
.apiHost("eu1.segmentapi.com")
.whateverElse()
.. instead of having to create an instance and then set them all afterwards.
Sources/Segment/Errors.swift
Outdated
| } | ||
|
|
||
| /// Reports an internal error to the user-defined error handler. | ||
| public func reportInternalError(_ error: Error, hardStop: Bool = false) { |
There was a problem hiding this comment.
nit: maybe critical instead of hardStop sounds more exception-like?
There was a problem hiding this comment.
named it fatal instead as it seemed more descriptive of what was going to happen, ie: YOUR APP WILL DIE.
| // flushInterval and flushAt can be modified post initialization | ||
| analytics.store.subscribe(self, initialState: true) { [weak self] (state: System) in | ||
| guard let self = self else { return } | ||
| self.flushTimer = QueueTimer(interval: state.configuration.values.flushInterval) { [weak self] in |
There was a problem hiding this comment.
Not sure how this works in Swift but wouldn't it also have to cancel the previous timer?
There was a problem hiding this comment.
QueueTimer is a wrapper on a dispatch source timer. Cancel is handled in dealloc.
errorHandlerto configuration so developer can receive errors we see internally.Affects #154 and #162.