-
Notifications
You must be signed in to change notification settings - Fork 109
Add Adjust device mode integration sample & example app #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
migs647
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| environment = ADJEnvironmentProduction | ||
| } | ||
|
|
||
| let adjustConfig = ADJConfig(appToken: settings.appToken, environment: environment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to protect against an empty appToken? Can it be nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It potentially could be, but let adjust report that error.
|
|
||
| Adjust.appDidLaunch(adjustConfig) | ||
|
|
||
| started = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to queue up any of these events if started hasn't happened yet?
.. If so, should we consider adding that feature to the core library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly; working on that separately from this PR.
No description provided.