Skip to content

Remove unused taskID. #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Remove unused taskID. #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3174dac
Remove unused taskID.
Feb 16, 2022
daef1e3
Remove use of taskID
Feb 16, 2022
b4ae07c
Restructure test failure expectation
Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Sources/Segment/Plugins/Platforms/iOS/iOSLifecycleMonitor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ extension SegmentDestination.UploadTaskInfo {
task.cancel()
application.endBackgroundTask(taskIdentifier)
}
self.taskID = taskIdentifier.rawValue

self.cleanup = {
application.endBackgroundTask(taskIdentifier)
Expand Down
1 change: 0 additions & 1 deletion Sources/Segment/Plugins/SegmentDestination.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public class SegmentDestination: DestinationPlugin {
let task: URLSessionDataTask
// set/used via an extension in iOSLifecycleMonitor.swift
typealias CleanupClosure = () -> Void
var taskID: Int = 0
var cleanup: CleanupClosure? = nil
}

Expand Down
5 changes: 3 additions & 2 deletions Tests/Segment-Tests/Analytics_Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,9 @@ final class Analytics_Tests: XCTestCase {

analytics.track(name: "testDestinationEnabled")

XCTExpectFailure()
wait(for: [expectation], timeout: 1.0)
XCTExpectFailure {
wait(for: [expectation], timeout: 1.0)
}
}
#endif

Expand Down