Skip to content

correct identify doc #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 9, 2022
Merged

correct identify doc #114

merged 5 commits into from
Feb 9, 2022

Conversation

@wenxi-zeng
Copy link
Contributor

@wenxi-zeng wenxi-zeng commented Feb 9, 2022 •
edited
Loading

  • correct identify docs
  • add badges

@wenxi-zeng
Copy link
Contributor Author

wenxi-zeng commented Feb 9, 2022

removed codecov changes, since codecov v1 uses bash uploader which has security issue and v2 does not support xcresult format yet. a workaround for v2 is to use a script to convert xcresult to json format, which is not very ideal. we can come back to this later.

see issue from codecov:
codecov/uploader#223

@wenxi-zeng wenxi-zeng marked this pull request as ready for review February 9, 2022 18:41
@wenxi-zeng wenxi-zeng requested review from bsneed and migs647 February 9, 2022 18:42
@wenxi-zeng wenxi-zeng merged commit c9d0c71 into main Feb 9, 2022
@wenxi-zeng wenxi-zeng deleted the wenxi/correct-identify-doc branch February 9, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsneed bsneed bsneed approved these changes

@migs647 migs647 Awaiting requested review from migs647

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenxi-zeng @bsneed