Add properties to parameters to the screen event #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bsneed would you mind reviewing this PR? |
alanjcharles
approved these changes
Nov 30, 2023
Contributor
alanjcharles
left a comment
alanjcharles
left a comment
There was a problem hiding this comment.
thanks @pbruz-grx !!
Contributor
Author
|
@alanjcharles could you also please push a tag with this update? I bet it's going to be |
Contributor
|
just pushed it- also bumped all of the dependencies. Let me know if anything else comes up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties for
screen_viewevents are not included into the parameters while we do expect them to be there.This PR adds them in the same way as it is done for "track" events.