#4148 Skeleton Translation #2 #4240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Jun 10, 2025
maxim-productengine
approved these changes
Jun 10, 2025
Ansariel
reviewed
Jun 10, 2025
indra/newview/gltf/llgltfloader.cpp
Outdated
| // Only supports xy 90 degree rotation | ||
| // Todo: figure out how to find skeleton's orientation Correctly | ||
| // when model is rotated at a triangle level | ||
| constexpr std::string right_shoulder_str = "mShoulderRight"; |
There was a problem hiding this comment.
GCC will probably be angry about this because GCC...
For now, it's better to use constexpr char right_shoulder_str[] = "mShoulderRight"; instead.
akleshchev
force-pushed
the
andreyk/viewer_4191
branch
from
4dff1ce to
19b106c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cheap hack to detect when skeleton is in a wrong rotation and adjust it.
I'm unwiling to dump more time into it. It works on models I have access to and I can return to it once I understand what's going on and what I'm doing.