macOS 26 build changes #4239
macOS 26 build changes #4239
Conversation
… from the SDK. Note: there was no warning or notice provided for AGL's removal.
There was a problem hiding this comment.
looks sensible.
Additionally we should probably get around to removing all the sysroot enforcement stuff from build-variables and the cmake environment. Xcode hasn't really supported using alternative macOS SDK versions in a very long time. If you are using Xcode 26 you get the SDK that came with 26, we should just roll with that.
|
|
||
| int string_length = [aString length]; | ||
| unichar text[string_length]; | ||
| unichar *text = new unichar[string_length]; |
There was a problem hiding this comment.
would slightly prefer using a vector and calling .data() where we pass it to APIs expecting a char* but no biggie
|
@brad-linden Yeah - I'll probably remove that in a follow up. There's a few things we should honestly just purge here - lots of deprecated stuff that we really just don't care about anymore that honestly is just gonna be noise when we eventually need to rip some of this stuff out anyways for a Metal port of the viewer. |
You may need to set LL_SKIP_REQUIRE_SYSROOT to ON if you're using Xcode 26 beta.
Takes care of the AGL deprecation (this was removed from the macOS 26 SDK - and I can't find any notes or deprecation notices for it).
Takes care of VLAs now emitting a warning on Xcode 26 creating an error in the viewer compile.
Still determining the best and fastest solution to the CEF missing Info.plist error when you attempt to run the viewer from Xcode - but produced builds will still work. May just add a post-build fixup to create the missing versions folder for the framework for now until we can produce a new CEF build that has this fix built-in. Will produce a separate PR for that.
Carbon is still (somehow) present despite AGL's removal.