#4170 Use GLTF scene definition for node traversal #4234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process nodes through the scene hierarchy as defined in the GLTF file instead of attempting to reconstruct parent-child relationships. This ensures proper import of models created by GLTF transform tools.
akleshchev
approved these changes
Jun 9, 2025
|
Should we even support more than one scene? |
|
Yes, GLTF files can have multiple scenes. |
|
They do, but should they really be uploaded all at once? instead of something like 'Select a scene to upload'. |
marchcat
commented
Jun 9, 2025
Comment on lines
+271
to
+272
| // Process the default scene (or first scene if no default) | ||
| S32 scene_idx = mGLTFAsset.mScene >= 0 ? mGLTFAsset.mScene : 0; |
There was a problem hiding this comment.
This is an answer to your question.
We don't load multiple scenes for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process nodes through the scene hierarchy as defined in the GLTF file instead of attempting to reconstruct parent-child relationships. This ensures proper import of models created by GLTF transform tools.