[#4221] Fix adding new skies to day cycle not saving #4227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfigs and mRayleightConfigs don't become null
|
1 thing I noticed is that the skip contains these 3 configs in it. Are they meant to just be skipped entirely now (which just takes the value from other)? Because last year before this became broken, they weren't being skipped since it was using the skip list inside of LLSettingsBase and not LLSettingsSky. If they are meant to be skipped, I'll need to make another small modification to the code to account for this, because right now the skip list is only used inside interpolateSDMap. |
akleshchev
approved these changes
Jun 10, 2025
marchcat
approved these changes
Jun 10, 2025
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4221
Fixes the above issue which was caused by mAbsorptionConfigs, mMieConfigs and mRayleighConfigs becoming null since interpolateSDMap wasn't interpolating and combining them properly as they are arrays and not maps. This causes the sky settings to fail the validation check when trying to save them, which resulted in the added sky not being saved into the day cycle. Now those 3 configs correctly get interpolated and should no longer end up null and failing the validation, and allow them to be saved correctly.