-
Notifications
You must be signed in to change notification settings - Fork 84
Close stale PRs #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ebf3d2e
to
d14c675
Compare
I'm hesitant to introduce this change. I see the point, but I've already offended at least one loyal contributor by ignoring PRs for that long or longer, and I'm afraid getting an automated message like this from neglect that's our fault, not theirs, might rub salt in an existing wound. |
Signal, are you sure 60 days is enough for LL to react? I suggest to bump this up to at least 365 days. On the other hand I think some automatic cleanup would be nice, again look at Bitbucket with some PRs that are years old and not even the original author pinging it. LL should be careful introducing this though. Because then you need to live up to your own standards. Or people will get rightfully annoyed having to ping their PRs or getting them closed. Though it would be fantastic if turnaround gets faster. |
@nat-goodspeed I think that's exactly the point: this automated behavior should spur LL to be more responsive in getting PRs merged. All participants of a PR will receive notifications when the bot tags PRs as stale and people can, rightful, yelp "hey: I'm waiting on LL, here." We can do a lot better, and I'd like to adopt tools and practices assuming good intent and outcome. |
Last time I checked there's PRs on BitBucket that have been open for over two years 😉 |
If two months (60 days) is too ambitious I could bump it to 90. |
From a contributors view 60 days of radio silence if already way too high. I don't think there is a "right" value here. Probably a life and learn over time. |
I received a begrudging go-ahead in slack. Let's try this out: if it's painful it should be removed. |
Mark PRs as stale after 60 days, close them automatically if no response after 7 days.