Skip to content

Conversation

bennettgoble
Copy link
Member

Mark PRs as stale after 60 days, close them automatically if no response after 7 days.

@nat-goodspeed
Copy link
Contributor

I'm hesitant to introduce this change. I see the point, but I've already offended at least one loyal contributor by ignoring PRs for that long or longer, and I'm afraid getting an automated message like this from neglect that's our fault, not theirs, might rub salt in an existing wound.

@Nicky-D
Copy link
Contributor

Nicky-D commented Nov 18, 2022

Signal, are you sure 60 days is enough for LL to react? I suggest to bump this up to at least 365 days.
Okay, my bad jokes aside: LL can be really slow to react, I know you guys care but are swamped with the normal work. I do understand.
But it is very often LL not reacting, sometimes month. To this day I still have some PRs on bitbucket that are so stale I cannot even delete them (because Bitbucket is dense or whatever).
Or the Linux PR that sat so long, it got killed by the HG>GIT switch. Waiting on LL input.

On the other hand I think some automatic cleanup would be nice, again look at Bitbucket with some PRs that are years old and not even the original author pinging it.

LL should be careful introducing this though. Because then you need to live up to your own standards. Or people will get rightfully annoyed having to ping their PRs or getting them closed. Though it would be fantastic if turnaround gets faster.
And also to not just sound negative, things got a better lately, Andrey for example has been very reposive

@bennettgoble
Copy link
Member Author

@nat-goodspeed I think that's exactly the point: this automated behavior should spur LL to be more responsive in getting PRs merged. All participants of a PR will receive notifications when the bot tags PRs as stale and people can, rightful, yelp "hey: I'm waiting on LL, here." We can do a lot better, and I'd like to adopt tools and practices assuming good intent and outcome.

@bennettgoble
Copy link
Member Author

Signal, are you sure 60 days is enough for LL to react? I suggest to bump this up to at least 365 days.

Last time I checked there's PRs on BitBucket that have been open for over two years 😉

@Nicky-D
Copy link
Contributor

Nicky-D commented Nov 18, 2022

Signal, are you sure 60 days is enough for LL to react? I suggest to bump this up to at least 365 days.

Last time I checked there's PRs on BitBucket that have been open for over two years 😉
image

There was also that one from Jonathan Yap (spelling) that been loitering there for I think 2 years but it finally did disappear.

@bennettgoble
Copy link
Member Author

If two months (60 days) is too ambitious I could bump it to 90.

@Nicky-D
Copy link
Contributor

Nicky-D commented Nov 18, 2022

If two months (60 days) is too ambitious I could bump it to 90.

From a contributors view 60 days of radio silence if already way too high. I don't think there is a "right" value here. Probably a life and learn over time.
Probably it's best to start with a time LL employees are comfortable with and everyone trying their best to be as responsive and fast as the can

@bennettgoble bennettgoble changed the base branch from master to contribute November 21, 2022 23:53
@bennettgoble
Copy link
Member Author

I received a begrudging go-ahead in slack. Let's try this out: if it's painful it should be removed.

@bennettgoble bennettgoble merged commit 59b826e into contribute Nov 22, 2022
@bennettgoble bennettgoble deleted the signal/stale branch November 22, 2022 00:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
akleshchev added a commit that referenced this pull request Feb 7, 2024
akleshchev added a commit that referenced this pull request Feb 7, 2024
akleshchev added a commit that referenced this pull request Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants