[#3954] Fix uploading small textures with OpenJPEG #3955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Apr 23, 2025
marchcat
approved these changes
Apr 25, 2025
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3954
Fixes the above issue by ensuring that as long as the image's width and height are >= MIN_IMAGE_SIZE, set their tile counts to a minimum of 1 and not 0. Previously they were being set to 0 which caused encoding to fail, and textures that were <64 pixels in either width or height would not upload while using OpenJPEG.
Also contains a minor refactor of an old log that was incorrectly logging a warning when encoding succeeded but said it was returning false.