World Map Find removing results undesirably

[Hecklezz]

Environment

Second Life Release 7.1.13.14343205944 (64bit)

Rest of environment-

Release Notes

You are at 135.2, 133.0, 27.2 in Cloud Sandbox 1 located at simhost-0204807ba3eb587d2.aditi
SLURL: secondlife://Aditi/secondlife/Cloud%20Sandbox%201/135/133/27
(global coordinates 305,799.0, 235,397.0, 27.2)
Elderberry Eclairs 2025-04-24.14648572313
Release Notes

CPU: Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (3600 MHz)
Memory: 16302 MB
OS Version: Microsoft Windows 10 64-bit (Build 19045.5737)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce RTX 2080/PCIe/SSE2

Windows Graphics Driver Version: 32.0.15.6636
OpenGL Version: 4.6.0 NVIDIA 566.36

Window size: 1634x928
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 64m
Bandwidth: 3000kbit/s
LOD factor: 1.5
Render quality: 4
Texture memory: 8192MB
Disk cache: Max size 1638.4 MB (10.1% used)

J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.24.2 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091639
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.5942f08

Packets Lost: 0/1,919 (0.0%)
May 06 2025 22:00:02

Description

PR with fix: #4038

Using the Find region functionality on the world map, depending on the response time of the Sim and the time it takes for the user to let go of the button, can result in the resulting regions not displaying all desired results.

This occurs because the Find button triggers its callback on both mouse-down, and mouse-up. So on mouse-down it sends a request to the Sim, which can reply and updates the search field box with the first result before the user lets go of Find. Then on mouse-up, since the search field box has been updated from the mouse-down event, it sends another request with the result of the first region it found just before, and then displays new results from the Sim with that new search query.

Using Enter/Return behaves correctly since this only sends 1 request to the Sim.

Video showing incorrect behaviour-
https://github.com/user-attachments/assets/efb2539a-e8ea-4849-bb01-4e5b5ab8e3be

Reproduction steps

1. Open World Map
2. Type part of a common region name ("Cloud" is a good example on the beta grid)
3. Hold down Find until it populates results
4. Let go of Find and see it repopulate the results and show less than the original search query since the search field was updated from the mouse-down request.

[AtlasLinden]

Passed QA.
Verified on Second Life Project 7.1.14.15976006598 (GLTF Mesh Import) on Win11/MacOS

It does feel odd that reselecting Find then fills the search box with the top result.
This fix removes the Find request triggering on mouse up but if a user decides to double click for whatever reason they are immediately left with only the top result.
A separate issue has been made to address the top result being added to the search box: #4339