Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Feb 14, 2019

  • adds tshark shortcut

@gpotter2
Copy link
Member Author

Ready to be reviewed

Copy link
Member

@p-l- p-l- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think I'd like to keep the good old tshark() function the way it works. Also, you can use tcpdump() and specify you want to run tshark.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #1848 into master will increase coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
+ Coverage   85.76%   85.77%   +<.01%     
==========================================
  Files         185      185              
  Lines       42473    42478       +5     
==========================================
+ Hits        36429    36434       +5     
  Misses       6044     6044
Impacted Files Coverage Δ
scapy/utils.py 76.09% <80%> (+0.01%) ⬆️
scapy/layers/tls/handshake_sslv2.py 91.32% <0%> (-0.38%) ⬇️
scapy/sendrecv.py 85.03% <0%> (-0.35%) ⬇️
scapy/contrib/isotp.py 88.77% <0%> (+0.45%) ⬆️

@gpotter2 gpotter2 mentioned this pull request Feb 22, 2019
27 tasks
@gpotter2
Copy link
Member Author

gpotter2 commented Mar 23, 2019

@guedou @p-l- Hi ! Please review when you find the time :)

@guedou
Copy link
Member

guedou commented Mar 24, 2019

Is it possible to test this?

@p-l- p-l- merged commit 2278685 into secdev:master Mar 24, 2019
@gpotter2
Copy link
Member Author

@guedou I’ll try to add a test. Should be possible

@gpotter2 gpotter2 deleted the textwireshark branch March 24, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants