Skip to content

Conversation

@deanmarcussen
Copy link
Collaborator

This introduces a Enumerable filters project which allows projecting an enumerable into a Filter Parsing arrangement, much as we can do with an IQuery currently.

Filtering on an IEnumerable is useful, for the case where we are using a single SQL document, i.e. like a TemplatesDocument where the items we want to filter on are contained in a dictionary, or list.

You may or may not want this in the YesSql project :) but I'm using it internally, so figured it was worth pushing up somewhere.

Note: There seems to be a slight bug in Partlot compilation which is causing the tests to fail randomly. I assume it's related to initialization, when initializing in parallel. Only applies to complied parsers.

I'll open an issue there to go with

@Skrypt
Copy link
Contributor

Skrypt commented Jul 28, 2025

@sebastienros Can you give a review for this one?

@sebastienros
Copy link
Owner

@copilot add a README.MD at the same level as the new project (not the tests) describing its goals and usages.

@Skrypt
Copy link
Contributor

Skrypt commented Aug 12, 2025

@deanmarcussen There is a compilation bug with this one. I fixed it locally. Want me to update your branch?

@deanmarcussen
Copy link
Collaborator Author

100% @Skrypt

@Skrypt
Copy link
Contributor

Skrypt commented Aug 13, 2025

I don't have access to this repository to commit directly to a branch. I will need to create a fork which is odd.

image

Here is a screenshot of the fix I did locally after merging latest main branch on top of your branch.

@deanmarcussen
Copy link
Collaborator Author

ok, probably just due to a change in Parlot, I'll try and make time today to pull and do the same fix

@deanmarcussen
Copy link
Collaborator Author

build fixed @Skrypt

@Skrypt
Copy link
Contributor

Skrypt commented Sep 25, 2025

@sebastienros While I can't promise that a PR will be done shortly for Orchard Core to show usage of this feature. Can we merge it for a future release still? I believe we need to merge this first anyway. Else, I need to keep that code in a custom module in OC.

Here is the related WIP branch: https://github.com/OrchardCMS/OrchardCore/tree/skrypt/shortcodes-filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants