Changed pong collision to use pygame built-in #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pong.py has been updated to use the pygame built-in collision detection. This also allowed the removal of some unwieldy code. While I can still see minor remaining issues with how the game currently reacts to a collision (sometimes jumping the ball a few pixels to the front of the paddle if detection is late), I believe this could be adjusted to be completely seamless for all resolutions.
Additional charges are the addition of comments to the Pong and RaycastMaze tests and the removal of a test for the now defunct and removed line_intersection function.
This implements the fix to issue #3.