introduce 'log_connection_messages' GUC setting #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
2 times, most recently
from
355a9f6 to
471f295
Compare
hughcapet
reviewed
Sep 26, 2022
src/backend/commands/variable.c
Outdated
|
|
||
| *extra = (void *) myextra; | ||
|
|
||
| if (log_connection_messages == NULL || log_connection_messages[0] == '\0') { |
There was a problem hiding this comment.
SplitIdentifierString already considers empty strings as ok, can't we get rid of this string?
There was a problem hiding this comment.
I've decided to keep it for now for the sake of being explicit in the code
|
+ tests should be extended to check the new GUC values, I guess |
yes, but let's wait with that untl the 1st round of feedback from the community |
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
from
471f295 to
7531ac9
Compare
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
2 times, most recently
from
0a20d43 to
2dca2c6
Compare
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
2 times, most recently
from
aea7a4c to
efafdb4
Compare
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
3 times, most recently
from
b85e0e4 to
4bf99bc
Compare
hughcapet
reviewed
Jan 31, 2023
| if (pg_strcasecmp(*newval, "all") == 0) | ||
| { | ||
| newlogconnect |= LOG_CONNECTION_ALL; | ||
| myextra = (int *) guc_malloc(ERROR, sizeof(int)); |
There was a problem hiding this comment.
shouldn't we check if myextra is NULL
obviously not. Thank you ! |
This patch removes 'log_connections' and 'log_disconnections' in favor of 'log_connection_messages', thereby introducing incompatibility Author: Sergey Dudoladov Reviewed-by: Justin Pryzby Discussion: https://www.postgresql.org/message-id/flat/CAA8Fd-qCB96uwfgMKrzfNs32mqqysi53yZFNVaRNJ6xDthZEgA%40mail.gmail.com
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
from
4bf99bc to
49a2ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch removes 'log_connections' and 'log_disconnections' in favor
of 'log_connection_messages', thereby introducing incompatibility
Author: Sergey Dudoladov
Reviewed-by:
Discussion:
https://www.postgresql.org/message-id/flat/CAA8Fd-qCB96uwfgMKrzfNs32mqqysi53yZFNVaRNJ6xDthZEgA%40mail.gmail.com