Make commit after every batch of inserts optional, with the default not to commit #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot to commit. For at least once semantics, it is not necessary to commit after every call to put(), as Kafka Connect will commit the kafka Offsets periodically. Doing it periodically will lead to less writes to the __consumer_offsets topic, and hence, less load on the Kafka brokers. The default is false, i.e not to commit offset after every set of INSERT operations. This is a change in behaviour of Kafka Connect ScyllaDB, but it leads to a significant decrease in number of produce requests on the Kafka brokers, which in production environments with high load is quite visible in Broker CPU consumption metrics.
forsberg
force-pushed
the
feature/optional-additional-commit
branch
from
263686f to
f29a0c3
Compare
dkropachev
force-pushed
the
master
branch
5 times, most recently
from
9d34a52 to
7a244f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For at least once semantics, it is not necessary to commit after every call to put(), as Kafka Connect will commit the kafka Offsets periodically. Doing it periodically will lead to less writes to the __consumer_offsets topic, and hence, less load on the Kafka brokers.
The default is false, i.e not to commit offset after every set of INSERT operations. This is a change in behaviour of Kafka Connect ScyllaDB, but it leads to a significant decrease in number of produce requests on the Kafka brokers, which in production environments with high load is quite visible in Broker CPU consumption metrics.