Skip to content

Conversation

@dkropachev
Copy link
Collaborator

Populate some fields, logos, owner information.
Remove version definition.
Add logos to the images/ folder.

Populate some fields, logos, owner information.
Remove version definition.
Add logos to the `images/` folder.
@dkropachev dkropachev self-assigned this Sep 23, 2025
Copy link
Collaborator

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is 1 typo, but otherwise seems good

</goals>
<configuration>
<title>Kafka Connect Scylla Database Connector</title>
<version>${project.version}-preview</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't version a required parameter? I don't see it readded

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will default to just ${project.version}, is that intended?

<title>Kafka Connect Scylla Database Connector</title>
<version>${project.version}-preview</version>
<name>kafka-connect-scylladb</name>
<title>Scylla Source Connector</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title is wrong, it's a Sink connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants