fix(typings): Improve TS typings #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
changed the title
stipsan
changed the title
|
🎉 This PR is included in version 2.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
icd2k3
added a commit
to icd2k3/scroll-into-view-if-needed
that referenced
this pull request
May 9, 2018
chore(deps): update dependency lint-staged to v7.1.0 (scroll-into-view#224) chore(deps): update dependency lint-staged to v7.1.0 (scroll-into-view#224) fix(typings): Improve TS typings (scroll-into-view#223) * prepare to add flowtype tests * improve the quality of the typescript libdefs * Improve typescript declarations * improve further * update readme etc * Update index.ts chore(deps): update dependency flowgen to v1.2.2 (scroll-into-view#226) fix(compute): custom behavior lack block and inline defaults (scroll-into-view#227) fix(compute): custom behavior missing block and inline defaults chore(deps): update dependency semantic-release to v15.4.0 (scroll-into-view#229) chore(readme): I think about Jest… a LOT! (scroll-into-view#230)
icd2k3
added a commit
to icd2k3/scroll-into-view-if-needed
that referenced
this pull request
May 9, 2018
chore(deps): update dependency lint-staged to v7.1.0 (scroll-into-view#224) chore(deps): update dependency lint-staged to v7.1.0 (scroll-into-view#224) fix(typings): Improve TS typings (scroll-into-view#223) * prepare to add flowtype tests * improve the quality of the typescript libdefs * Improve typescript declarations * improve further * update readme etc * Update index.ts chore(deps): update dependency flowgen to v1.2.2 (scroll-into-view#226) fix(compute): custom behavior lack block and inline defaults (scroll-into-view#227) fix(compute): custom behavior missing block and inline defaults chore(deps): update dependency semantic-release to v15.4.0 (scroll-into-view#229) chore(readme): I think about Jest… a LOT! (scroll-into-view#230)
icd2k3
added a commit
to icd2k3/scroll-into-view-if-needed
that referenced
this pull request
May 9, 2018
chore(deps): update dependency lint-staged to v7.1.0 (scroll-into-view#224) chore(deps): update dependency lint-staged to v7.1.0 (scroll-into-view#224) fix(typings): Improve TS typings (scroll-into-view#223) * prepare to add flowtype tests * improve the quality of the typescript libdefs * Improve typescript declarations * improve further * update readme etc * Update index.ts chore(deps): update dependency flowgen to v1.2.2 (scroll-into-view#226) fix(compute): custom behavior lack block and inline defaults (scroll-into-view#227) fix(compute): custom behavior missing block and inline defaults chore(deps): update dependency semantic-release to v15.4.0 (scroll-into-view#229) chore(readme): I think about Jest… a LOT! (scroll-into-view#230)
icd2k3
added a commit
to icd2k3/scroll-into-view-if-needed
that referenced
this pull request
May 10, 2018
chore(deps): update dependency lint-staged to v7.1.0 (scroll-into-view#224) chore(deps): update dependency lint-staged to v7.1.0 (scroll-into-view#224) fix(typings): Improve TS typings (scroll-into-view#223) * prepare to add flowtype tests * improve the quality of the typescript libdefs * Improve typescript declarations * improve further * update readme etc * Update index.ts chore(deps): update dependency flowgen to v1.2.2 (scroll-into-view#226) fix(compute): custom behavior lack block and inline defaults (scroll-into-view#227) fix(compute): custom behavior missing block and inline defaults chore(deps): update dependency semantic-release to v15.4.0 (scroll-into-view#229) chore(readme): I think about Jest… a LOT! (scroll-into-view#230)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this PR was meant to include flowtype definitions, but flowgen didn't produce satisfying results with our
typings/*.d.tsfiles (especially not when importing types).