Skip to content

Conversation

@khell
Copy link
Contributor

@khell khell commented Apr 28, 2017

Hi, I have two changes.

Windows Compatibility
Use rimraf package which mirrors rm -rf behaviour. This is for compatibility with Windows on the
clean script.

CommonJS interop issue with exports.default
Because you're using Babel 6, exports default gets transformed to exports.default as ES6 module. For CommonJS interoperability it is needed to now import this module with .default which is not desirable as evident by #116. babel-plugin-add-module-exports reverts to Babel 5 functionality, which does the same as above, but also adds a module.exports line for CommonJS.

@stipsan stipsan merged commit fbf7079 into scroll-into-view:master Oct 1, 2017
@stipsan
Copy link
Member

stipsan commented Oct 1, 2017

Thanks @khell! 😄

stipsan added a commit that referenced this pull request Oct 29, 2017
stipsan added a commit that referenced this pull request Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants