Remove obsolete response objects from Fastly configuration #9744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Supports POD-277
Changes:
Primary change: remove obsolete response objects from Fastly configuration before attempting to update or add any. This helps avoid exceeding the ~100-count limit.
Supporting changes:
fastly-extended.js, so I could tell what I was doing.fastly-extended.jsinto a class so that the type annotations would work.Errorinstances for error reporting inconfigure-fastly.js, as opposed to usingstring.stringwas incorrect as it violates theasynclibrary's expectationsasynclibrary, we were sometimes passing a string and sometimes passing the output of thefastlylibrary'srequestcall, which usesError.Test Coverage:
Existing tests updated