Match Scratch 2.0 order of execution #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2017 14:44
The `allStacksAndOwnersDo` function in Scratch 2.0 runtime iterates targets in reverse and projects sometimes rely on that for correct initialization. If, for example, each sprite runs a "go back 999 layers" or "go to front" block as its first action, the order of execution will determine the ordering of the layers. This change makes Scratch 3.0 match the Scratch 2.0 execution order.
cwillisf
added
pr - good to merge
pr - needs review
and removed
pr - changes requested
pr - good to merge
labels
thisandagain
approved these changes
Feb 15, 2017
rschamp
approved these changes
Feb 15, 2017
stefania11
pushed a commit
to mitmedialab/cognimates-vm
that referenced
this pull request
Mar 31, 2018
…om-15.6.0 Update react-dom to the latest version 🚀
|
Has this change been pushed out to the develop branch? |
|
@griffpatch Yes. Could you file a new issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Working toward scratchfoundation/scratch-render#62
Proposed Changes
The
allStacksAndOwnersDofunction in Scratch 2.0 runtime iterates targets in reverse. The corresponding function in Scratch 3.0,allScriptsDo, iterates targets in forward order. This change makes Scratch 3.0 match the Scratch 2.0 execution order.Reason for Changes
Projects sometimes rely on that for correct initialization. If, for example, each sprite runs a "go back 999 layers" or "go to front" block as its first action, the order of execution will determine the ordering of the layers. This change causes such projects to run more correctly in Scratch 3.0.
Test Coverage
This change adds an integration test to verify that "when green flag" hats in multiple sprites execute in the same order as when run in the Scratch 2.0 implementation.