Added some unit tests for some thread functions #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. It's nice to have unit tests in addition to the existing integration test coverage. Any reason you decided not to test |
thisandagain
approved these changes
Feb 10, 2017
Closed
|
I didn't add tests for functions that require a renderTarget and Blocks to be defined for reasons that now seem silly. I'll add those in today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Partially resolves #345
Proposed Changes
Adds a number of tests to call different functions and check output.
Reason for Changes
Because it's important to test things, especially threads.
Test Coverage
Yes. ;)