Fix for Support ARGB for pen #393 #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires fix to scratch-render before this will work (see: 6f5acfee7b961d71237f1fd50bb3d5a5139c527e)
thisandagain
suggested changes
Jan 27, 2017
src/blocks/scratch3_pen.js
Outdated
| penState.penAttributes.color4f[1] = rgb.g / 255.0; | ||
| penState.penAttributes.color4f[2] = rgb.b / 255.0; | ||
| if (rgb.hasOwnProperty('a')) { // Will there always be an 'a'? | ||
| penState.penAttributes.color4f[3] = rgb.a/255.0; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/util/color.js
Outdated
| var g = (decimal >> 8) & 0xFF; | ||
| var b = decimal & 0xFF; | ||
| return {r: r, g: g, b: b}; | ||
| return {r: r, g: g, b: b, a: a>0 ? a : 255}; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Had to update the test scripts to handle the alpha channel, also I note that all the hex tests are using CSS notation, not scratch notation (which is 0x not #)
|
Ok, I've fixed the lint issues - I also had to add to the test scripts to handle the new alpha values. Do I need to do anything to move the pull request forward? |
thisandagain
approved these changes
Jan 27, 2017
|
Thanks @griffpatch ! |
Closed
stefania11
pushed a commit
to mitmedialab/cognimates-vm
that referenced
this pull request
Mar 31, 2018
…esize-bug Show workspace before triggering resize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires fix to scratch-render before this will work.
See:
6f5acfee7b961d71237f1fd50bb3d5a5139c527e