Fix pixelate effect on CPU path #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
fixelate
branch
2 times, most recently
from
33603a0 to
8636eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #573
Proposed Changes
This PR changes the
EffectTransform.transformPoint's pixelate routine to divide byu_pixelateinstead of multiplying.Reason for Changes
In order to calculate the size of a "pixelated" pixel, the fragment shader divides the size of the skin by
u_pixelate. Previously, the CPU path (EffectTransform) erroneously multiplied byu_pixelate, resulting in the pixelate effect not being properly applied.Test Coverage
A "pixelate effect touching" test has been added.