Switch from Chromeless to Puppeteer for tests #537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #564
Proposed Changes
This PR switches the integration tests from Chromeless to Puppeteer.
Puppeteer recommends using its bundled version of Chromium, but this would result in downloading a couple hundred megabytes of Chromium every time you ran
npm install. Instead, I've added a script that only downloads the bundled Chromium when you actually run the tests, and removed Chrome as an addon from.travis.yml.Reason for Changes
Chromeless was deprecated mid-2018 and has not been updated since then.
When investigating #535, I thought it would be a good idea to run tests on both the CPU and GPU, to ensure they give the same results. Since doing so would require modifying the test framework anyway, I thought it'd be a good idea to update the tests to use up-to-date software. As such, this PR is somewhat of a prerequisite to running CPU/GPU parity tests. [EDIT: running tests on both the CPU and GPU was already implemented in #419; it was simply reverted. Nevertheless, moving away from a deprecated library is still a good idea]