Revert "Revert "Skin alter push"" #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix calculateRotationCenter() for SVG skins
cwillisf
requested changes
Sep 4, 2019
Contributor
cwillisf
left a comment
cwillisf
left a comment
There was a problem hiding this comment.
In its current form, this breaks the costume size indicators in the costume tab:
Modifying the costume causes the size indicator to update to an apparently-correct value so it looks like it might be an initialization or order-of-operations issue.
Contributor
…-size-synchronously-2
Set SVG skin size synchronously
cwillisf
approved these changes
Sep 5, 2019
Contributor
cwillisf
left a comment
cwillisf
left a comment
There was a problem hiding this comment.
Tested locally, these fixes seem to do the trick.
Thanks, @mzgoddard and @adroitwhiz!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #493
This PR needs investigation as to whether this original PR (e.g. #470) or #467 was failing gui integration tests.
Fix (if necessary) and re-make this PR.
cc/ @cwillisf @mzgoddard