Skip to content

Better scala version detection #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2019
Merged

Better scala version detection #115

merged 3 commits into from
Sep 14, 2019

Conversation

eyalroth
Copy link
Contributor

Fixes #96.
Fixes #97.

This improves the detection of the scala library version in three ways:

  1. Checks for the library in any compilation-related configuration (compile, compileOnly, implementation, etc).
  2. Using the resolved configuration, the plugin is now compatible with resolution strategies that may be configured by other plugins, such as Spring's dependency management and Scala multi-version.
  3. Using the resolved configuration, the plugin now supports dynamic versions, such as 2.12.+.

@eyalroth
Add detection of scala version via 'implementation' and 'compileOnly'…
1c4ea7f 
… configurations
@eyalroth
Remove redundant functional test for Scala 2.11 (which is also failin…
b0c01a7 
…g Travis CI build)
@eyalroth
Resolve scala library version according to the resolved compilation c…
0c01830 
…lasspath

This commit adds support for any plugin which manipulates the configuration via resolution strategy.
@eyalroth eyalroth mentioned this pull request Sep 14, 2019
Closed
@maiflai maiflai merged commit 1270643 into scoverage:master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiflai maiflai maiflai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eyalroth @maiflai