test(interfaces): Test for missing ip or ifconfig #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a fallback to `ifconfig` if `ip` doesn't exist, but it wasn't tested anywhere that does have `ip` (pretty sure that's all of our current distro tests). Introduce a parameterized fixture that "hides" `ip` or `ifconfig` and, use it in tests. Also introduce another test that actually makes sure that we find the correct interfaces. Follow up to scop#1090
akinomyoga
approved these changes
Jun 16, 2025
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a fallback to
ifconfigifipdoesn't exist, but it wasn't tested anywhere that does haveip(pretty sure that's all of our current distro tests).Introduce a parameterized fixture that "hides"
iporifconfigand, use it in tests.Also introduce another test that actually makes sure that we find the correct interfaces.
Follow up to #1090