Skip to content

[MRG] ROSE #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 68 commits into from
Sep 20, 2020
Merged

[MRG] ROSE #754

merged 68 commits into from
Sep 20, 2020

Conversation

andrealorenzon
Copy link
Contributor

Reference Issue

N/A

What does this implement/fix? Explain your changes.

Implementation of ROSE over-sampler method

Any other comments?

N/A

Andrea Lorenzon added 30 commits August 21, 2020 11:34
@andrealorenzon
Copy link
Contributor Author

Code should be ok. I have some issue with documentation build, though. Can anyone help me to give a direction, or tips about what's wrong?

@andrealorenzon andrealorenzon changed the title Rose [MRG] ROSE Sep 18, 2020
@andrealorenzon andrealorenzon marked this pull request as draft September 18, 2020 10:06
@andrealorenzon andrealorenzon marked this pull request as ready for review September 18, 2020 10:07
@hayesall hayesall self-requested a review September 18, 2020 20:45
@hayesall hayesall self-assigned this Sep 18, 2020
hayesall
hayesall requested changes Sep 19, 2020
View reviewed changes
Copy link
Member

@hayesall hayesall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!

A few final changes (see comments), then I think this will be good to merge.

@hayesall
Copy link
Member

Can you also add a note to the "Enhancements" section for 0.7?

https://github.com/scikit-learn-contrib/imbalanced-learn/blob/master/doc/whats_new/v0.7.rst

@andrealorenzon
Copy link
Contributor Author

Can you also add a note to the "Enhancements" section for 0.7?

https://github.com/scikit-learn-contrib/imbalanced-learn/blob/master/doc/whats_new/v0.7.rst

Sure.

- Added Random Over-Sampling Examples (ROSE) class.
  :pr:`745` by :user:`Andrea Lorenzon <andrealorenzon>`.

hayesall
hayesall approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@hayesall hayesall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for the last few fixes.

Otherwise, LGTM!

@hayesall hayesall merged commit 6e9eeff into scikit-learn-contrib:master Sep 20, 2020
andrealorenzon added a commit to andrealorenzon/imbalanced-learn that referenced this pull request Sep 28, 2020
@andrealorenzon
Merge pull request #1 from scikit-learn-contrib/master
550bd13 
✨ ROSE (scikit-learn-contrib#754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hayesall hayesall hayesall approved these changes

Assignees

@hayesall hayesall

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrealorenzon @pep8speaks @hayesall