fix: more testing and label support #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
henryiii
commented
Jul 7, 2021
henryiii
commented
- tests: nicer config
- fix: support label and better testing
henryiii
commented
Jul 7, 2021
| raise NotImplementedError("Currently overlay is not supported") | ||
|
|
||
| if self._stack[0].ndim != 1: | ||
| import hist.plot |
There was a problem hiding this comment.
Besides piggy-backing on our existing mechanism for replacing this, it also makes it easy to monkeypatch in tests, too!
henryiii
commented
Jul 7, 2021
| return iter(self._stack) | ||
|
|
||
| def plot(self, *, overlay: None = None, **kwargs: Any) -> "List[Hist1DArtists]": | ||
| def __len__(self) -> int: |
henryiii
commented
Jul 7, 2021
|
|
||
|
|
||
| @nox.session(python=ALL_PYTHONS) | ||
| @nox.session(python=ALL_PYTHONS, reuse_venv=True) |
There was a problem hiding this comment.
I think this is safe. Let's try it, anyway; it saves quite a few (15-20) seconds for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.