fix: modify error message and add warning #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejnovak
reviewed
Jul 6, 2021
Co-authored-by: Andrzej Novak <[email protected]>
for more information, see https://pre-commit.ci
|
Have added the tests, @LovelyBuggies. |
|
LGTM now. |
henryiii
reviewed
Jul 6, 2021
Co-authored-by: Henry Schreiner <[email protected]>
henryiii
reviewed
Jul 6, 2021
| if set(data_dict) != set(range(len(args), self.ndim)): | ||
| raise TypeError("All axes must be accounted for in fill") | ||
| raise TypeError( | ||
| "All axes must be accounted for in fill, you may have used a disallowed name in the axes" |
There was a problem hiding this comment.
Eventually I'd only do this if you have an axis with a disallowed name, but this is fine for now.
I'd eventually make the disallowed_names a global DISALLOWED_NAMES: Final[set[str]] = {...}, then we could see if there is any overlap between these, and only suggest the "you may have used a disallowed name in the axes" part if there is a chance of this - most users seeing this error probably are making normal mistakes, not using one of these special names
There was a problem hiding this comment.
Oh okay, we can make it global after this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233